Add proactive desync detection for wrapped names#1107
Open
storywithoutend wants to merge 3 commits intomainfrom
Open
Add proactive desync detection for wrapped names#1107storywithoutend wants to merge 3 commits intomainfrom
storywithoutend wants to merge 3 commits intomainfrom
Conversation
Detect out-of-sync wrapped names by comparing expiry timestamps before the NameWrapper internally expires. Previously, desynced names were only detected after the wrapper expiry passed (when owner shows as 0x0). Now checks: wrapperExpiry !== registrarExpiry + gracePeriod This allows users to see the "Name misconfigured" warning and repair their names before encountering failed contract calls. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Deploying ens-app-v3 with
|
| Latest commit: |
85fd96f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://29bd6649.ens-app-v3.pages.dev |
| Branch Preview URL: | https://feature-fet-2894-fix-desynci.ens-app-v3.pages.dev |
The wrapper data mock was using GRACE_PERIOD (milliseconds) while the expiry mock uses gracePeriod in seconds, causing unit mismatch in the isWrappedNameDesynced check. This made all wrapped name tests fail with unexpected 'desynced' status. - Replace GRACE_PERIOD constant with 7776000 (seconds) in wrapper mock - Add grace-period variants for emancipated and locked wrapper data types - Update test configs to use correct grace-period wrapper types - Fix typo: "licked" -> "locked" in test name Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
storywithoutend
changed the base branch from
main
to
feature/fet-2911-update-ensjs-version-in-manager-v3
storywithoutend
changed the base branch from
feature/fet-2911-update-ensjs-version-in-manager-v3
to
main
…imestamp rounding The strict equality checks for expiry timestamps after name extension failed because the blockchain contract doesn't always produce an exact 365-day extension. Aligned all assertions with the tolerance pattern already used elsewhere in the same test file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect out-of-sync wrapped names by comparing expiry timestamps before the NameWrapper internally expires. Previously, desynced names were only detected after the wrapper expiry passed (when owner shows as 0x0).
Now checks: wrapperExpiry !== registrarExpiry + gracePeriod
This allows users to see the "Name misconfigured" warning and repair their names before encountering failed contract calls.
on sepolia, a test name desynced-active-name.eth was created to simulate this situation.